Bug 152081 - Cell comment box visible after hiding the row it belongs
Summary: Cell comment box visible after hiding the row it belongs
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium normal
Assignee: Gabor Kelemen (allotropia)
URL:
Whiteboard: target:7.5.0 target:7.4.4
Keywords:
Depends on:
Blocks: Calc-Comments
  Show dependency treegraph
 
Reported: 2022-11-17 10:12 UTC by Gabor Kelemen (allotropia)
Modified: 2024-05-27 13:03 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Example file from Calc with comment in hidden row (9.57 KB, application/vnd.oasis.opendocument.spreadsheet)
2022-11-17 10:12 UTC, Gabor Kelemen (allotropia)
Details
Screenshot of the issue in Calc and the same setup in Excel 2016 (180.11 KB, image/png)
2022-11-17 10:17 UTC, Gabor Kelemen (allotropia)
Details
Same files with visible rows (52.41 KB, image/png)
2022-11-17 10:21 UTC, Gabor Kelemen (allotropia)
Details
comment using my calc (8.93 KB, application/vnd.oasis.opendocument.spreadsheet)
2022-11-17 11:55 UTC, johnks
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Kelemen (allotropia) 2022-11-17 10:12:47 UTC
Created attachment 183637 [details]
Example file from Calc with comment in hidden row

Attached example file contains a comment attached to cell B4 and View - Comments is enabled.
The row 4 is hidden, yet the comment is still visible, misleadingly pointing to the cell B5.

1, Open attached document
2, Observe the comment is visible, pointing to the top of cell B5
3, Highlight rows 3-5, right click, choose Show Rows.
4, Now the red comment marker becomes visible and the comment is shown belonging to B4
5, Right click on row 4, choose Hide Rows. The comment is still visible.

Expected: Hiding the row (or column) hides the comments attached to its cells.

Version: 7.5.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 3c0be5564afe1b9cc843a49aba88b72af74c43ab
CPU threads: 14; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: de-DE (hu_HU); UI: en-US
Calc: threaded

also happens in older versions back to 3.5, so not a regression.

This is similar to bug 46444 which is the same issue in case of autofiltering.
Comment 1 Gabor Kelemen (allotropia) 2022-11-17 10:17:08 UTC
Created attachment 183638 [details]
Screenshot of the issue in Calc and the same setup in Excel 2016

In comparison Excel hides the comments belonging to hidden rows/columns.
Comment 2 Gabor Kelemen (allotropia) 2022-11-17 10:21:17 UTC
Created attachment 183639 [details]
Same files with visible rows
Comment 3 johnks 2022-11-17 11:54:35 UTC
what.... kind of comment is this? i am using calc and my comment and your comment looks different....

are you sure you right clicked on a cell and "insert comment"? did you do this or some other manner?

i have attached a file with a single cell text and comment on that cell. see if this file works for you or not




Version: 7.4.2.3 / LibreOffice Community
Build ID: 382eef1f22670f7f4118c8c2dd222ec7ad009daf
CPU threads: 4; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-IN (en_IN); UI: en-US
Flatpak
Calc: threaded
Comment 4 johnks 2022-11-17 11:55:51 UTC
Created attachment 183642 [details]
comment using my calc

please confirm if my sheet has the same show comment visible, for me at least it does not. 

i checked your file. i am able to drag the comment box which makes me think you made the comment in a non-standard manner
Comment 5 m_a_riosv 2022-11-18 00:09:44 UTC
(In reply to johnks from comment #4)
> ..
> please confirm if my sheet has the same show comment visible, for me at
> least it does not. 
> ..--
No, your file has not the comments visible.
Menu/View/Comments.
Comment 6 m_a_riosv 2022-11-18 00:11:00 UTC
Reproducible
Version: 7.5.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: a81e957f5026373f3935390c786c21416fc74fcc
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: es-ES (es_ES); UI: en-US Calc: CL threaded
Comment 7 Commit Notification 2022-11-22 18:14:46 UTC
Balazs Varga committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/b71303fe1b06c1711ad80e5a0269d41ccaaad8e1

tdf#46444 tdf#152081 sc: hide notes in hidden rows or columns

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Commit Notification 2022-11-23 16:20:57 UTC
Balazs Varga committed a patch related to this issue.
It has been pushed to "libreoffice-7-4":

https://git.libreoffice.org/core/commit/2194fdaef01f667dd4ef476504981867ad2c80e2

tdf#46444 tdf#152081 sc: hide notes in hidden rows or columns

It will be available in 7.4.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 m_a_riosv 2022-11-23 21:32:57 UTC
Verified
Version: 7.5.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 1435c5b12646269e2b5b58ec7d51626dce6505db
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: es-ES (es_ES); UI: en-US
Calc: CL threaded
Comment 10 Commit Notification 2022-11-26 21:42:01 UTC
Balazs Varga committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/c9807faad6a154b57a99adfdf9b02bd9e588250f

Related: tdf#46444 tdf#152081 sc: add unit test for note hiding

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Commit Notification 2022-12-02 09:51:38 UTC
Balazs Varga committed a patch related to this issue.
It has been pushed to "libreoffice-7-4":

https://git.libreoffice.org/core/commit/e42b39389dd4a9cb7e98c27e032c8d663a1ac95f

Related: tdf#46444 tdf#152081 sc: add unit test for note hiding

It will be available in 7.4.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 12 Shane Clay 2023-05-24 03:26:20 UTC Comment hidden (spam)