Bug 155484 - FILESAVE ODT Extra page break when converting specific docx to odt
Summary: FILESAVE ODT Extra page break when converting specific docx to odt
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.3.0.3 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:24.2.0 target:7.6.3
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Writer-Page-Break DOCX-Fields
  Show dependency treegraph
 
Reported: 2023-05-25 10:34 UTC by Gabor Kelemen (allotropia)
Modified: 2024-05-14 10:11 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Example docx file, anonimized in Writer (18.72 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2023-05-25 10:34 UTC, Gabor Kelemen (allotropia)
Details
The example file saved as odt in current master (35.06 KB, application/vnd.oasis.opendocument.text)
2023-05-25 10:34 UTC, Gabor Kelemen (allotropia)
Details
The example file and its odt version side by side in Writer (121.58 KB, image/png)
2023-05-25 10:35 UTC, Gabor Kelemen (allotropia)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Kelemen (allotropia) 2023-05-25 10:34:15 UTC
Created attachment 187489 [details]
Example docx file, anonimized in Writer

Attached 2 page docx file was originally made in Word, then anonimized in Writer.

When this is saved to odt format, an extra soft page break in the second table appears close to the top, making it 3 pages instead of 2.

1. Open attached docx file
2. Save as odt, reload
-> document is now 3 pages instead of 2, the second table is split

Version: 7.6.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: 73a82b425b4dc02ef4ad3946b71c067a6411045c
CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: hu-HU (hu_HU.UTF-8); UI: en-US
Calc: threaded

Was good in 7.2, bibisected in 7.3 to:

https://git.libreoffice.org/core/+/6433dc223f6d21570e7132c4a580d186a5d5a334

author	Michael Stahl <michael.stahl@allotropia.de>	Fri Nov 19 16:08:57 2021 +0100
committer	Thorsten Behrens <thorsten.behrens@allotropia.de>	Thu Dec 23 12:08:38 2021 +0100
tree dc630b38e7d4cc9267b60499d086773e24b8615d
parent a7fb9ec83d08d28383918a40a0f9ccbbdccbf506 [diff]

Revert "Revert "sw_fieldmarkhide: init fieldmark mode from options""
Comment 1 Gabor Kelemen (allotropia) 2023-05-25 10:34:40 UTC
Created attachment 187490 [details]
The example file saved as odt in current master
Comment 2 Gabor Kelemen (allotropia) 2023-05-25 10:35:16 UTC
Created attachment 187491 [details]
The example file and its odt version side by side in Writer
Comment 3 Gabor Kelemen (allotropia) 2023-05-25 10:37:13 UTC
Adding CC to: Michael Stahl

and see also bugs mentioning the same commit
Comment 4 Stéphane Guillou (stragu) 2023-05-25 11:17:45 UTC
Repro with:

Version: 7.6.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: f3aab159f1c1e00c25e6b4ca1e50813bc343f4f3
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded
Comment 5 Thorsten Behrens (allotropia) 2024-05-13 14:07:19 UTC
Un-CCing developer. It's unclear at this stage, if we can find time to look into it further.
Comment 6 Stéphane Guillou (stragu) 2024-05-14 10:11:07 UTC
No repro anymore in:

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 0dcaff6043e1f24ce0fa354dff80a86e40622247
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: CL threaded

Bibisected fix with linux-64-7.6 repo to first good build [6824afc4d5944d509b047e14eb8f35fe67b26287] which is 1d71e51db56e9f8692dda1d66b0d2d661e0f7711, a cherrypick of:

commit b8521d969ab5be4fc947e467d4afe969f9d3b563
author	Miklos Vajna 	Mon Sep 25 08:38:28 2023 +0200
committer	Miklos Vajna 	Mon Sep 25 09:41:41 2023 +0200
tdf#157263 sw floattable: prefer join over split after moving fwd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157233

Thank you Miklos!